Fixed bug in Quaternion that didn't allow for operator/ with a const-qualified operand b
This commit is contained in:
parent
b8b3005cb2
commit
f2519fd085
@ -10,28 +10,28 @@
|
||||
#include "gcccompat.h"
|
||||
#endif
|
||||
|
||||
using namespace Eule;
|
||||
namespace Eule {
|
||||
|
||||
Quaternion::Quaternion()
|
||||
{
|
||||
Quaternion::Quaternion()
|
||||
{
|
||||
v = Vector4d(0, 0, 0, 1);
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion::Quaternion(const Vector4d values)
|
||||
{
|
||||
Quaternion::Quaternion(const Vector4d values)
|
||||
{
|
||||
v = values;
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion::Quaternion(const Quaternion& q)
|
||||
{
|
||||
Quaternion::Quaternion(const Quaternion& q)
|
||||
{
|
||||
v = q.v;
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion::Quaternion(const Vector3d eulerAngles)
|
||||
{
|
||||
Quaternion::Quaternion(const Vector3d eulerAngles)
|
||||
{
|
||||
Vector3d eulerRad = eulerAngles * Deg2Rad;
|
||||
|
||||
#ifndef _EULE_NO_INTRINSICS_
|
||||
@ -96,44 +96,44 @@ Quaternion::Quaternion(const Vector3d eulerAngles)
|
||||
#endif
|
||||
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion::~Quaternion()
|
||||
{
|
||||
Quaternion::~Quaternion()
|
||||
{
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::operator= (const Quaternion& q)
|
||||
{
|
||||
Quaternion Quaternion::operator= (const Quaternion& q)
|
||||
{
|
||||
InvalidateCache();
|
||||
|
||||
v = q.v;
|
||||
|
||||
return (*this);
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::operator* (const Quaternion& q) const
|
||||
{
|
||||
Quaternion Quaternion::operator* (const Quaternion& q) const
|
||||
{
|
||||
return Quaternion(Vector4d(
|
||||
v.w * q.v.x + v.x * q.v.w + v.y * q.v.z - v.z * q.v.y,
|
||||
v.w * q.v.y + v.y * q.v.w + v.z * q.v.x - v.x * q.v.z,
|
||||
v.w * q.v.z + v.z * q.v.w + v.x * q.v.y - v.y * q.v.x,
|
||||
v.w * q.v.w - v.x * q.v.x - v.y * q.v.y - v.z * q.v.z
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::operator*(const double scale) const
|
||||
{
|
||||
Quaternion Quaternion::operator*(const double scale) const
|
||||
{
|
||||
return Quaternion(v * scale);
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::operator/ (Quaternion& q) const
|
||||
{
|
||||
Quaternion Quaternion::operator/ (const Quaternion& q) const
|
||||
{
|
||||
return ((*this) * (q.Inverse()));
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion& Quaternion::operator*= (const Quaternion& q)
|
||||
{
|
||||
Quaternion& Quaternion::operator*= (const Quaternion& q)
|
||||
{
|
||||
InvalidateCache();
|
||||
|
||||
Vector4d bufr = v;
|
||||
@ -143,41 +143,41 @@ Quaternion& Quaternion::operator*= (const Quaternion& q)
|
||||
v.w = bufr.w * q.v.w - bufr.x * q.v.x - bufr.y * q.v.y - bufr.z * q.v.z; // w
|
||||
|
||||
return (*this);
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion& Quaternion::operator*=(const double scale)
|
||||
{
|
||||
Quaternion& Quaternion::operator*=(const double scale)
|
||||
{
|
||||
InvalidateCache();
|
||||
|
||||
v *= scale;
|
||||
return (*this);
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion& Quaternion::operator/= (const Quaternion& q)
|
||||
{
|
||||
Quaternion& Quaternion::operator/= (const Quaternion& q)
|
||||
{
|
||||
InvalidateCache();
|
||||
|
||||
(*this) = (*this) * q.Inverse();
|
||||
return (*this);
|
||||
}
|
||||
}
|
||||
|
||||
Vector3d Quaternion::operator*(const Vector3d& p) const
|
||||
{
|
||||
Vector3d Quaternion::operator*(const Vector3d& p) const
|
||||
{
|
||||
return RotateVector(p);
|
||||
}
|
||||
}
|
||||
|
||||
bool Quaternion::operator== (const Quaternion& q) const
|
||||
{
|
||||
bool Quaternion::operator== (const Quaternion& q) const
|
||||
{
|
||||
return (v.Similar(q.v)) || (v.Similar(q.v * -1));
|
||||
}
|
||||
}
|
||||
|
||||
bool Quaternion::operator!= (const Quaternion& q) const
|
||||
{
|
||||
bool Quaternion::operator!= (const Quaternion& q) const
|
||||
{
|
||||
return (!v.Similar(q.v)) && (!v.Similar(q.v * -1));
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::Inverse() const
|
||||
{
|
||||
Quaternion Quaternion::Inverse() const
|
||||
{
|
||||
const std::lock_guard<std::mutex> lock(lock_inverseCache);
|
||||
|
||||
if (!isCacheUpToDate_inverse)
|
||||
@ -188,20 +188,20 @@ Quaternion Quaternion::Inverse() const
|
||||
}
|
||||
|
||||
return Quaternion(cache_inverse);
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::Conjugate() const
|
||||
{
|
||||
Quaternion Quaternion::Conjugate() const
|
||||
{
|
||||
return Quaternion(Vector4d(-v.x, -v.y, -v.z, v.w));
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::UnitQuaternion() const
|
||||
{
|
||||
Quaternion Quaternion::UnitQuaternion() const
|
||||
{
|
||||
return (*this) * (1.0 / v.Magnitude());
|
||||
}
|
||||
}
|
||||
|
||||
Vector3d Quaternion::RotateVector(const Vector3d& vec) const
|
||||
{
|
||||
Vector3d Quaternion::RotateVector(const Vector3d& vec) const
|
||||
{
|
||||
Quaternion pure(Vector4d(vec.x, vec.y, vec.z, 0));
|
||||
|
||||
//Quaternion f = Conjugate() * pure * (*this);
|
||||
@ -216,10 +216,10 @@ Vector3d Quaternion::RotateVector(const Vector3d& vec) const
|
||||
toRet.z = f.v.z;
|
||||
|
||||
return toRet;
|
||||
}
|
||||
}
|
||||
|
||||
Vector3d Quaternion::ToEulerAngles() const
|
||||
{
|
||||
Vector3d Quaternion::ToEulerAngles() const
|
||||
{
|
||||
const std::lock_guard<std::mutex> lock(lock_eulerCache);
|
||||
|
||||
if (!isCacheUpToDate_euler)
|
||||
@ -249,10 +249,10 @@ Vector3d Quaternion::ToEulerAngles() const
|
||||
}
|
||||
|
||||
return cache_euler;
|
||||
}
|
||||
}
|
||||
|
||||
Matrix4x4 Quaternion::ToRotationMatrix() const
|
||||
{
|
||||
Matrix4x4 Quaternion::ToRotationMatrix() const
|
||||
{
|
||||
const std::lock_guard<std::mutex> lock(lock_matrixCache);
|
||||
|
||||
if (!isCacheUpToDate_matrix)
|
||||
@ -295,43 +295,41 @@ Matrix4x4 Quaternion::ToRotationMatrix() const
|
||||
}
|
||||
|
||||
return cache_matrix;
|
||||
}
|
||||
}
|
||||
|
||||
Vector4d Quaternion::GetRawValues() const
|
||||
{
|
||||
Vector4d Quaternion::GetRawValues() const
|
||||
{
|
||||
return v;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::AngleBetween(const Quaternion& other) const
|
||||
{
|
||||
Quaternion Quaternion::AngleBetween(const Quaternion& other) const
|
||||
{
|
||||
return other * Conjugate();
|
||||
}
|
||||
}
|
||||
|
||||
void Quaternion::SetRawValues(const Vector4d values)
|
||||
{
|
||||
void Quaternion::SetRawValues(const Vector4d values)
|
||||
{
|
||||
InvalidateCache();
|
||||
|
||||
v = values;
|
||||
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Quaternion Quaternion::Lerp(const Quaternion& other, double t) const
|
||||
{
|
||||
Quaternion Quaternion::Lerp(const Quaternion& other, double t) const
|
||||
{
|
||||
return Quaternion(v.Lerp(other.v, t)).UnitQuaternion();
|
||||
}
|
||||
}
|
||||
|
||||
void Quaternion::InvalidateCache()
|
||||
{
|
||||
void Quaternion::InvalidateCache()
|
||||
{
|
||||
isCacheUpToDate_euler = false;
|
||||
isCacheUpToDate_matrix = false;
|
||||
isCacheUpToDate_inverse = false;
|
||||
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
namespace Eule
|
||||
{
|
||||
std::ostream& operator<< (std::ostream& os, const Quaternion& q)
|
||||
{
|
||||
os << "[" << q.v << "]";
|
||||
|
@ -31,7 +31,7 @@ namespace Eule
|
||||
Quaternion operator* (const Quaternion& q) const;
|
||||
|
||||
//! Divides (applies)
|
||||
Quaternion operator/ (Quaternion& q) const;
|
||||
Quaternion operator/ (const Quaternion& q) const;
|
||||
|
||||
//! Also multiplies
|
||||
Quaternion& operator*= (const Quaternion& q);
|
||||
|
Loading…
x
Reference in New Issue
Block a user